Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New api for html file #70

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

MathieuCarriere
Copy link
Collaborator

Branch to be merged after keplermapper PR of gudhi has been merged

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MathieuCarriere MathieuCarriere marked this pull request as ready for review November 23, 2023 09:40
Copy link

review-notebook-app bot commented Jan 24, 2024

View / edit / reply to this conversation on ReviewNB

VincentRouvreau commented on 2024-01-24T09:25:09Z
----------------------------------------------------------------

Line #4.        voronoi_samples=100, verbose=True)

It seems to me you are using the verbosity more for debug purposes than for interesting information for the user, no ?

If this is the case, I think we could have a global variable verbose at the beginning of the notebook, False by default, and that could be changed for the entire notebook:

python

verbose = False # set it to True for debug information

...

cover_complex = GraphInducedComplex(..., verbose=verbose)

...

cover_complex = MapperComplex(..., verbose=verbose)

...


Copy link

review-notebook-app bot commented Jan 24, 2024

View / edit / reply to this conversation on ReviewNB

VincentRouvreau commented on 2024-01-24T09:25:10Z
----------------------------------------------------------------

Line #1.    cover_complex = MapperComplex(

This is the new cover complex interfaces that requires gudhi 3.9.0.

In

gudhi!=3.7.0 # cf. https://github.com/GUDHI/TDA-tutorial/issues/65
you should change this line with:

gudhi>=3.9.0


@MathieuCarriere
Copy link
Collaborator Author

Thanks @VincentRouvreau, I agree with your comments, I've just implemented them

@VincentRouvreau VincentRouvreau merged commit 3ab7c33 into GUDHI:master Jan 26, 2024
1 check passed
@MathieuCarriere MathieuCarriere deleted the New-API-for-HTML-file branch January 26, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants