Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perslay cleanup #64

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Perslay cleanup #64

merged 4 commits into from
Jan 10, 2023

Conversation

VincentRouvreau
Copy link
Contributor

@VincentRouvreau VincentRouvreau commented Jan 3, 2023 •
edited
Loading

Remove utils/experiments.py as it was not used by perslay (but introduced by it).
And fix some issues:

  • tqdm
  • deprecated np.int

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mglisse
mglisse approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@mglisse mglisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the current situation that we have a notebook that doesn't work with the latest release of gudhi?
Should we do something about atol, later?

@VincentRouvreau
Copy link
Contributor Author

Should we do something about atol, later?

Yes, maybe not on this PR. There is already an issue about ATOL

@VincentRouvreau VincentRouvreau merged commit 7ec804e into GUDHI:master Jan 10, 2023
@VincentRouvreau VincentRouvreau deleted the perslay_cleanup branch January 10, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglisse mglisse mglisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentRouvreau @mglisse