Hot Swapping Cables & Wires #3336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagger8243
changed the title
FourIsTheNumber
added
the
new feature
chochem
added
the
ongoing freeze - do not merge
dagger8243
changed the title
NotAPenguin0
requested changes
Oct 11, 2024
| handCable.mInsulated, | ||
| handCable.mCanShock)); | ||
|
|
||
| world.setBlock(x, y, z, Blocks.air); |
There was a problem hiding this comment.
Do you really need to swap the entire block? You already are setting the MTE at this position, and the blocks for the different cables should be exactly the same (possibly meta is different, but you can just change the meta value).
There was a problem hiding this comment.
if i dont then it functions as one cable and looks like another
There was a problem hiding this comment.
That means you're not sending an update to the renderer most likely, forcing a block update is just a roundabout way of doing so and not really ideal.
Dream-Master
removed
the
ongoing freeze - do not merge
|
@dagger8243 any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video below describes it best:
2024-10-06.02-24-05.mp4
To do:
Figure out that error that pops upCleaner replacement made it go away on its ownFix the mConnections variable when new one is placedFair tradeMODKEYSet to LCONTROL by default, need to figure out keybindings