-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a line returns to list items and making events conditional on homepage #223
Conversation
So, I don't want this to be a big deal, but I'd consider some of these kinds of changes more like a patch release How does that strike you? There's no need to hold off on these changes over a versioning discussion, but going forward it might make sense to be more strict. If only to keep us from hotfixing all the time, and limiting that to only when it's really necessary. It's annoying and sometimes painful from holding back on improvements, but it might help our workflow and sanity?
It may feel like I'm being a bit of a process stickler here, and I guess I am a bit. But the process is the product to some degree here. |
|
|
What was improved
Unordered lists were not rendering on two page because there was not a space between the line of text above it and the start of the un-ordered list. This fix makes those unordered lists render properly.
Made the events listing on the Homepage not appear if there are no events(Make the events listing on the Homepage conditional #169)
Removed the contact page and all references to it and redirected it to the About page
Added a Contact Us section to the About Page https://federalist-proxy.app.cloud.gov/preview/gsa/digitalgov.gov/release-2.1.1/about/
making it clear that part of the event is online https://federalist-proxy.app.cloud.gov/preview/gsa/digitalgov.gov/release-2.1.1/event/workshop-making-government-websites-with-github-federalist-us-web-design-standards/
removed the event-type prefix from event titles https://federalist-proxy.app.cloud.gov/preview/gsa/digitalgov.gov/release-2.1.1/events/