Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle fullname more gracefully and do a bugfix release #39

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Handle fullname more gracefully and do a bugfix release #39

merged 3 commits into from
Dec 6, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Dec 6, 2023

The rest of the exceptions we see are from here when the TAST is walked.
Need to look deeper if we can do something about that.

@dawedawe dawedawe requested a review from nojaf December 6, 2023 14:29
@dawedawe dawedawe marked this pull request as ready for review December 6, 2023 14:52
nojaf
nojaf approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dawedawe dawedawe merged commit ce18cba into main Dec 6, 2023
1 check passed
@dawedawe dawedawe deleted the handle_fullname branch December 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawedawe @nojaf