Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement LoggingArgFuncNotFullyAppliedAnalyzer #38

Merged
merged 6 commits into from
Dec 4, 2023
Merged

implement LoggingArgFuncNotFullyAppliedAnalyzer #38

merged 6 commits into from
Dec 4, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Dec 1, 2023

No description provided.

nojaf
nojaf requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
I wouldn't mix the analyzers, I think you can work around it.

src/FSharp.Analyzers/LoggingArgFuncNotFullyAppliedAnalyzer.fs Outdated Show resolved Hide resolved
src/FSharp.Analyzers/LoggingArgFuncNotFullyAppliedAnalyzer.fs Outdated Show resolved Hide resolved
@dawedawe dawedawe marked this pull request as ready for review December 4, 2023 11:17
nojaf
nojaf previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shall we ship a new version with these?

@dawedawe
Copy link
Contributor Author

dawedawe commented Dec 4, 2023

Looks good. Shall we ship a new version with these?

Yes, I think two new analyzers are enough for a new release. I added the changelog entries but need a new approval.

@nojaf nojaf merged commit afca64d into main Dec 4, 2023
1 check passed
@nojaf nojaf deleted the loggingargfuncnotfullyappliedanalyzer branch December 4, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawedawe @nojaf