Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partialappanalyzer #10

Merged
merged 14 commits into from
Oct 16, 2023
Merged

Add partialappanalyzer #10

merged 14 commits into from
Oct 16, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Oct 4, 2023 •
edited
Loading

No description provided.

@dawedawe dawedawe marked this pull request as ready for review October 5, 2023 09:41
@dawedawe
Copy link
Contributor Author

I think this is good to go in now.

nojaf
nojaf previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Can you create a follow-up issue to revisit the visitor code eventually?

src/FSharp.Analyzers/PartialAppAnalyzer.fs Outdated Show resolved Hide resolved
@dawedawe
Copy link
Contributor Author

Great work. Can you create a follow-up issue to revisit the visitor code eventually?

I created #13 for this.

@nojaf nojaf merged commit 01f5c11 into main Oct 16, 2023
1 check passed
@nojaf nojaf deleted the add_partialappanalyzer branch October 16, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawedawe @nojaf