Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ? operators from proc-macro generated code #369

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

toyboot4e
Copy link
Member

This is an internal clean up PR. Hopefully it can also improve the compile time a bit.

From Twitter:

@toyboot4e
Copy link
Member Author

toyboot4e commented Sep 27, 2022

CI build time on Windows changed from 8m 45s to 8m 5s. I think it doesn't mean anything though -- maybe they were run on different machine?

@toyboot4e toyboot4e closed this Sep 27, 2022
@toyboot4e toyboot4e reopened this Sep 27, 2022
@lenscas
Copy link
Contributor

lenscas commented Sep 27, 2022

CI build time on Windows changed from 8m 45s to 8m 5s. I think it doesn't mean anything though -- maybe they were run on different machine?

I don't think you can use github actions to measure performance as it will probably have quite a bit of variance as it is running on a VM at best and there are probably quite a few other VM's running on the same actual hardware doing their own things

@mrDIMAS mrDIMAS merged commit 54898cc into FyroxEngine:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants