Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove old Stage editor keybind functionality #3882

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sphis-Sinco
Copy link

Does this PR close any issues? If so, link them below.

#3850

Briefly describe the issue(s) fixed.

  • The Stage Editor keybind functionality has been removed as to fix an issue where the old stage editor would be enabled and basically break gameplay (even when resetting the song) until you leave to the menu and reenter the song.

Include any relevant screenshots or videos.

Before:

bugfix-oldstageeditor-before.mp4

After:

bugfix-oldstageeditor-after.mp4

@github-actions github-actions bot added haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes labels Nov 19, 2024
@sphis-Sinco sphis-Sinco changed the title Remove old Stage editor keybind functionality [BUGFIX] Remove old Stage editor keybind functionality Nov 19, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Nov 20, 2024

Thanks for addressing this issue! I can't verify the functionality of this PR, but I do have a few tips for your future PRs:

If screenshots or videos aren't the best way to convey the function of your PR, please only include a description of the function. Many PRs can be more easily understood with just a clear description!

For any videos you do choose to include, please trim them to the relevant content and necessary context. It'll help us understand what you changed!

Thanks again for submitting PRs!

@sphis-Sinco
Copy link
Author

Thanks for addressing this issue! I can't verify the functionality of this PR, but I do have a few tips for your future PRs:

If screenshots or videos aren't the best way to convey the function of your PR, please only include a description of the function. Many PRs can be more easily understood with just a clear description!

For any videos you do choose to include, please trim them to the relevant content and necessary context. It'll help us understand what you changed!

Thanks again for submitting PRs!

No problem!

Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants