Modify charting and animation events in Spookeez and Spookeez (Pico Mix) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spookeez: - Adds missing note in Hard chart Sections 14 and 18 - Moves Skid and Pump's cheer animation 10 ms forward to ensure it plays - Adds the missing second cheer animation to both sides Spookeez (Pico Mix): - Adds the same missing notes for Skid and Pump in Hard - Corrects the position of a note in Section 18 and 34 by 1/16 note in all difficulties - Adds cheering events for both sides - Adds functional cheer animation to pico-dark.json - Adds non-functional cheer animation to pico-playable.json
EliteMasterEric
added
status: pending triage
EliteMasterEric
changed the title
EliteMasterEric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes FunkinCrew/Funkin#2652
Partially fixes FunkinCrew/Funkin#3480
Fixes FunkinCrew/Funkin#3175 and dupe fixes FunkinCrew/Funkin#3678
Fixes FunkinCrew/Funkin#3307
Description
This pull request fixes a variety of issues with both Spookeez and Spookeez (Pico Mix).
Spookeez:
Spookeez (Pico Mix):
Follow-up
Adding the cheer animation to only Pico's dark variant will lead to an inconsistency between the lit and dark sprites when lightning strikes (same issue as FunkinCrew/Funkin#3529).
To address this, I've added the cheer animation to pico-playable.json as well. Once his spritesheet and .xml files are updated, Pico will be able to cheer perfectly!