close previous db-load job, an other one #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karry
approved these changes
Feb 18, 2024
|
Please close loadJob in even on |
See commit 5b62a91. And not rely on job destructor, it seems that Qt may postpone object deletion after deleteLater() invocation for very long time. In such situation data are still loading and job is holding database read-lock.
janbar
force-pushed
the
close-previous-db-load-2
branch
from
20149b0 to
e59cd6e
Compare
Finally we managed to fix all the annoying reentrant locks. +1 |
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit 5b62a91.
And not rely on job destructor, it seems that Qt may postpone object deletion after deleteLater() invocation for very long time. In such situation data are still loading and job is holding database read-lock.
@Karry, an other one is fixed here. I catched it on mobile device (Android). I guess the issue appear too on device slower than desktop used to develop or test.