-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Simple Carousel Documentation and Contribution Documention #352
Conversation
Updating contributing documentation to reflect run script changes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
We publish to Vercel, the preview is published here. Locally, you can run the docs website by
And the examples should be runnable with
The contribution guide appears to be outdated a bit |
…ributing documentation
Thanks a ton for the feedback here. I've also updated the docs particularly to add a section for Documentation based on this, tested it locally, updated that one would require Node 18 to run this (which differed from the code overall in my experience) as a callout. |
@hartzis Hi there! 👋 Wanted you to be aware that I submitted a PR for documentation for React Swipeable's Simple Carousel, and some updates for the Contribution Documentation to get it in line with some of the changes as I was getting up to speed with contributing. Would love your feedback, and thanks a ton! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome clarifying documentation updates 🙏🎉
Thank you a ton! |
Description
This PR updates the documentation for the Simple Carousel, giving a more contextual update to the Simple Carousel documentation. In addition, the Contribution Documentation was updated as it had discrepancies with the run script listed in
package.json
.Type of Change
How Has This Been Tested?
This is an update to documentation, not code that has any functional dependency.
Of note, this has not been published to Github Pages, but is first in an PR to be reviewed. Running the Python script even after re-running the build doesn't allow this to be previewed entirely locally.
If this should be stripped down to more of just code snippets than a walkthrough, that can be done too.