Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template literals for swipe direction callbacks #241

Closed
wants to merge 3 commits into from

Conversation

stefvhuynh
Copy link
Contributor

@stefvhuynh stefvhuynh commented Apr 8, 2021

  • Uses template literals for swipe call callbacks
  • Upgrades to [email protected], which uses typescript@4

TODO before merge

  • These changes have caused the package to exceed the size limit by 82 bytes. This could be due to the dependency update, so we should decide how to handle this (bump up the limit slightly or try to slim the bundle a bit).

@hartzis
Copy link
Collaborator

hartzis commented Feb 18, 2022

Closing PR for now. We'll try to tackle this in v7 but after we remove microbundle and use rollup.

@hartzis hartzis closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants