Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 fix deltas #200

Merged
merged 6 commits into from
Aug 28, 2020
Merged

V6 fix deltas #200

merged 6 commits into from
Aug 28, 2020

Conversation

upatel32
Copy link
Contributor

Made delta = current - initial for both x and y. Adjusted direction labels and test snapshots to reflect the new definition of deltas.

@upatel32 upatel32 requested a review from hartzis August 20, 2020 16:02
@upatel32 upatel32 self-assigned this Aug 20, 2020
@upatel32 upatel32 linked an issue Aug 20, 2020 that may be closed by this pull request
Copy link
Collaborator

@hartzis hartzis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add description/details of change to migration doc?

@upatel32
Copy link
Contributor Author

Could you add description/details of change to migration doc?

Added!


## Major Changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add to list of major changes

@upatel32 upatel32 merged commit 62d93d3 into v6 Aug 28, 2020
@hartzis hartzis deleted the v6-fix-deltas branch September 7, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confused by deltaX and deltaY
2 participants