Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison operators: check type compatibility #160

Open
ForNeVeR opened this issue Jul 30, 2022 · 1 comment · Fixed by #170
Open

Comparison operators: check type compatibility #160

ForNeVeR opened this issue Jul 30, 2022 · 1 comment · Fixed by #170
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors hacktoberfest kind:feature New feature or request status:help-wanted Open for contributors

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Jul 30, 2022 •
edited
Loading

See // TODO[#160] in the code:

Cesium/Cesium.CodeGen/Ir/Expressions/BinaryOperators/ComparisonBinaryOperatorExpression.cs

Line 44 in 116782c

// TODO[#160]: check if operand types are compatible?

@ForNeVeR ForNeVeR added kind:feature New feature or request status:help-wanted Open for contributors area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors labels Jul 30, 2022
ForNeVeR added a commit to impworks/Cesium that referenced this issue Jul 30, 2022
@ForNeVeR
(ForNeVeR#160) ComparisonBinaryOperatorExpression: connect the TODO n…
9948300 
…ote with the issue
ForNeVeR added a commit that referenced this issue Jul 30, 2022
@ForNeVeR
(#160) ComparisonBinaryOperatorExpression: connect the TODO note with…
116782c 
… the issue
@Fantoom Fantoom mentioned this issue Jul 31, 2022
Merged
@ForNeVeR
Copy link
Owner Author

ForNeVeR commented Aug 7, 2022

Partially resolved by #170: we've added more conversion features, but it seems there's still no check?

@ForNeVeR ForNeVeR reopened this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors hacktoberfest kind:feature New feature or request status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type compatibility check Fantoom/Cesium
1 participant
@ForNeVeR