(#354) CodeGen: improve validation of vararg CLI imports

ForNeVeR · Nov 18, 2023 · 12b22d4 · 12b22d4
1 parent 862f518
commit 12b22d4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Cesium.CodeGen/Contexts/TranslationUnitContext.cs b/Cesium.CodeGen/Contexts/TranslationUnitContext.cs
@@ -234,11 +234,15 @@ private FunctionInfo ProcessCliImport(FunctionInfo declaration, MethodReference
 
         List<ParameterInfo> ProcessParameters(ICollection<ParameterInfo> parameters)
         {
-            // For now, only wrap the interop types.
-            if (implementation.Parameters.Count != parameters.Count)
+            var areParametersValid =
+                implementation.Parameters.Count == parameters.Count
+                || declaration.Parameters.IsVarArg; // TODO: A better check for interop functions + vararg.
+            if (!areParametersValid)
+            {
                 throw new CompilationException(
                     $"Parameter count for function {declaration.CliImportMember} " +
                     $"doesn't match the parameter count of imported CLI method {implementation.FullName}.");
+            }
 
             return parameters.Zip(implementation.Parameters)
                 .Select(pair =>