-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add remote IP filter to allow a connection from remote kms #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeseung-bae
changed the title
feat: add kms remote IP filter
feat: add remote IP filter to allow a connection from remote ostracon-kms
Aug 8, 2023
jaeseung-bae
force-pushed
the
feat/kms-ip-filter
branch
from
August 8, 2023 09:05
bac9a77
to
59838a0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
+ Coverage 66.52% 66.62% +0.09%
==========================================
Files 283 285 +2
Lines 37869 37915 +46
==========================================
+ Hits 25192 25260 +68
+ Misses 10874 10855 -19
+ Partials 1803 1800 -3
|
jaeseung-bae
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Aug 9, 2023
jaeseung-bae
changed the title
feat: add remote IP filter to allow a connection from remote ostracon-kms
feat: add remote IP filter to allow a connection from remote kms
Aug 9, 2023
jaeseung-bae
changed the title
feat: add remote IP filter to allow a connection from remote kms
feat: add remote IP filter to allow a connection from remote kms.
Aug 9, 2023
jaeseung-bae
changed the title
feat: add remote IP filter to allow a connection from remote kms.
feat: add remote IP filter to allow a connection from remote kms
Aug 9, 2023
ulbqb
reviewed
Aug 9, 2023
torao
reviewed
Aug 10, 2023
torao
reviewed
Aug 10, 2023
…or "unix" connection type
jaeseung-bae
force-pushed
the
feat/kms-ip-filter
branch
2 times, most recently
from
August 11, 2023 11:52
0aa6e6d
to
4658301
Compare
jaeseung-bae
force-pushed
the
feat/kms-ip-filter
branch
from
August 12, 2023 00:16
4658301
to
44a8045
Compare
ulbqb
approved these changes
Aug 16, 2023
torao
approved these changes
Aug 17, 2023
This was referenced Aug 24, 2023
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a description of the changes that this PR introduces and the files that
are the most critical to review.