Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update golang version to 1.20 #665

Merged
merged 14 commits into from
Jul 25, 2023
Merged

build: update golang version to 1.20 #665

merged 14 commits into from
Jul 25, 2023

Conversation

0Tech
Copy link
Contributor

@0Tech 0Tech commented Jul 14, 2023

Description

Closes: #664

@0Tech 0Tech self-assigned this Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #665 (1c50c4a) into main (1cab268) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   66.51%   66.43%   -0.08%     
==========================================
  Files         283      283              
  Lines       37818    37821       +3     
==========================================
- Hits        25155    25128      -27     
- Misses      10868    10889      +21     
- Partials     1795     1804       +9
Files Changed Coverage Δ
rpc/core/routes.go 0.00% <ø> (ø)
rpc/jsonrpc/server/http_server.go 89.61% <100.00%> (ø)
rpc/jsonrpc/server/ws_handler.go 35.71% <100.00%> (+0.77%) ⬆️

... and 12 files with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review July 19, 2023 05:22
@0Tech 0Tech requested review from torao, tnasu and ulbqb as code owners July 19, 2023 05:22
tnasu
tnasu requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@tnasu tnasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-check the below:

  • Makefile
  • REAEME.md
  • test/e2e/docker/Dockerfile

@ulbqb
Copy link
Member

ulbqb commented Jul 19, 2023 •
edited
Loading

Please update these files.

ostracon/README.md

Line 9 in 80d5dd0

**Node**: Requires [Go 1.18+](https://golang.org/dl/)

ostracon/Makefile

Line 261 in 80d5dd0

DOCKER_IMG = golang:1.18-alpine

ostracon/test/e2e/docker/Dockerfile

Line 10 in 80d5dd0

# librocksdb-dev installed by apt with golang:1.18 is still 6.11, so we have to build it from the latest 6.x sources.

@0Tech 0Tech requested a review from tnasu July 19, 2023 09:19
@tnasu tnasu mentioned this pull request Jul 25, 2023
Merged
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jul 25, 2023
@0Tech 0Tech merged commit d57e463 into Finschia:main Jul 25, 2023
@0Tech 0Tech deleted the golang branch July 25, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnasu tnasu tnasu approved these changes

@torao torao torao approved these changes

@ulbqb ulbqb Awaiting requested review from ulbqb ulbqb is a code owner

Assignees

@0Tech 0Tech

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update golang version to 1.20
4 participants
@0Tech @ulbqb @torao @tnasu