Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mockery was supposed to be installed in the local environment, but that assumption is not necessarily guaranteed. It is something that a repository should guarantee.
In this PR, a fix was made to manage the mockery package with
go.mod
and execute it directly with script.The path is specified as a relative path according to Tendermint as follows.
The reason is to avoid conflicts during backporting.
Ex.
This PR exists in
tendermint/tendermint
, but since Go 1.17 we cango run
external packages directly, so we don't need to use docker.Main:
tendermint/tendermint#9094
Two
Mockery
improvement PR exist in the 34.x version, butcherry-pick
is not desirable because it includes more than just Mock changes.tendermint/tendermint#8863
tendermint/tendermint#9114
This PR is for making Mockery work correctly.