Fix to change expected of test according to build tag #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 65.99% 66.10% +0.10%
==========================================
Files 279 279
Lines 38028 38028
==========================================
+ Hits 25097 25138 +41
+ Misses 11129 11089 -40
+ Partials 1802 1801 -1
|
torao
approved these changes
Dec 12, 2022
tnasu
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mismatch between the constant VrfProofSize and the result of the function GenerateVRFProof() as well as the constant VrfOutputSize and the result of the function VRFVerify() will lead to the failure of the benchmark test, benchmarkVRFProof().
I fixed the constants VrfProofSize and VrfOutputSize to change according to the build tag and to invert the expected and actual values passed in the function require.Equalf().