Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix inconsistencies between the validators and voters #522

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Dec 6, 2022

Description

There are many inconsistencies between the validators and voters in recordMetrics function. I fix them with reference to consensus/state.go.

@ulbqb ulbqb marked this pull request as ready for review December 6, 2022 07:11
@ulbqb ulbqb requested review from Kynea0b, torao and tnasu as code owners December 6, 2022 07:11
@ulbqb ulbqb requested a review from Mdaiki0730 December 6, 2022 07:11
@ulbqb ulbqb self-assigned this Dec 6, 2022
@ulbqb ulbqb force-pushed the fix/maverick_metrics branch from 4f28632 to d57877d Compare December 6, 2022 07:13
@ulbqb ulbqb marked this pull request as draft December 6, 2022 07:20
@ulbqb ulbqb force-pushed the fix/maverick_metrics branch from d57877d to 11e6f94 Compare December 6, 2022 07:35
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #522 (11e6f94) into main (160e52f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   65.81%   65.79%   -0.02%     
==========================================
  Files         279      279              
  Lines       38057    38057              
==========================================
- Hits        25047    25041       -6     
- Misses      11209    11217       +8     
+ Partials     1801     1799       -2     
Impacted Files Coverage Δ
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
blockchain/v0/reactor.go 65.43% <0.00%> (-4.70%) ⬇️
privval/socket_listeners.go 79.72% <0.00%> (-4.06%) ⬇️
privval/signer_listener_endpoint.go 88.88% <0.00%> (-2.39%) ⬇️
types/voter_set.go 85.80% <0.00%> (-0.84%) ⬇️
p2p/conn/connection.go 79.80% <0.00%> (-0.58%) ⬇️
consensus/reactor.go 74.66% <0.00%> (-0.27%) ⬇️
libs/os/os.go 28.78% <0.00%> (ø)
libs/cli/helper.go 61.44% <0.00%> (ø)
statesync/chunks.go 86.32% <0.00%> (ø)
... and 7 more

@ulbqb ulbqb marked this pull request as ready for review December 6, 2022 07:45
@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Dec 6, 2022
@ulbqb ulbqb merged commit 3970776 into Finschia:main Dec 6, 2022
@ulbqb ulbqb deleted the fix/maverick_metrics branch December 6, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants