-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of the ValidatorsHash, Round and Proof #510
Add validation of the ValidatorsHash, Round and Proof #510
Conversation
4e6f34d
to
7c99da2
Compare
7c99da2
to
b322fdf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 65.60% 65.68% +0.07%
==========================================
Files 279 279
Lines 37988 38032 +44
==========================================
+ Hits 24923 24981 +58
+ Misses 11268 11255 -13
+ Partials 1797 1796 -1
|
1f82b3a
to
e4cea2b
Compare
e4cea2b
to
7730830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why did you do that? I think it should do the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you add the below in the description why do you modify it?
#cgo darwin,arm64 CFLAGS: -I./sodium/darwin_arm64/include/
#cgo darwin,arm64 LDFLAGS: -L./sodium/darwin_arm64/lib -lsodium
I got it. Thank you for your advice. |
Description
Since the Header contains the ValidatorHash, Round, and Proof, the Header.ValidateBasic() should perform the stateless validation of the ValidatorsHash, Round and Proof as well.
We also added the below for libsodium support on M1 macs.
PR Check List