-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tendermint/tm-db #446
Merged
Merged
Use tendermint/tm-db #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 65.48% 65.41% -0.07%
==========================================
Files 278 278
Lines 37926 37920 -6
==========================================
- Hits 24834 24804 -30
- Misses 11284 11304 +20
- Partials 1808 1812 +4
|
torao
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Jul 25, 2022
tnasu
commented
Jul 25, 2022
The explanation seems too brief. |
@torao Updated the description. See that. Thanks. |
torao
approved these changes
Jul 26, 2022
zemyblue
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tendermint/tm-db-v0.6.6
: https://github.com/tendermint/tendermint/blob/v0.34.19/go.mod#L37line/tm-db
Background
line/lbm-sdk
stop usingline/tm-db
and etc.line/tm-db
is not maintained quickly and effectivelyline/ostracon
back-port from the upstream oftendermint/tendermint
, then it makes a lot of conflicts while usingline/tm-db
I think using
tendermint/tm-db
has many merites.