Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tendermint/tm-db #446

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Use tendermint/tm-db #446

merged 1 commit into from
Jul 27, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Jul 25, 2022

Description

Background

I think using tendermint/tm-db has many merites.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #446 (6cfbb56) into main (f42887f) will decrease coverage by 0.06%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   65.48%   65.41%   -0.07%     
==========================================
  Files         278      278              
  Lines       37926    37920       -6     
==========================================
- Hits        24834    24804      -30     
- Misses      11284    11304      +20     
- Partials     1808     1812       +4     
Impacted Files Coverage Δ
cmd/ostracon/commands/light.go 14.45% <0.00%> (ø)
consensus/replay_file.go 0.00% <0.00%> (ø)
light/store/db/db.go 62.61% <ø> (ø)
p2p/trust/store.go 72.72% <ø> (ø)
state/store.go 51.38% <ø> (ø)
statesync/stateprovider.go 0.00% <0.00%> (ø)
store/store.go 68.01% <ø> (ø)
state/indexer/block/kv/kv.go 56.12% <83.33%> (ø)
abci/example/kvstore/kvstore.go 73.83% <100.00%> (ø)
abci/example/kvstore/persistent_kvstore.go 51.98% <100.00%> (ø)
... and 17 more

@tnasu tnasu self-assigned this Jul 25, 2022
@tnasu tnasu marked this pull request as ready for review July 25, 2022 06:33
@tnasu tnasu requested review from Kynea0b and torao as code owners July 25, 2022 06:33
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jul 25, 2022
node/node_test.go Show resolved Hide resolved
rpc/core/blocks_test.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
@torao
Copy link
Contributor

torao commented Jul 26, 2022

The explanation seems too brief.
Is there an Issue or related PR that explains why this change is necessary?

@tnasu
Copy link
Member Author

tnasu commented Jul 26, 2022

@torao Updated the description. See that. Thanks.

@tnasu tnasu requested a review from zemyblue July 27, 2022 01:26
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit 81b4fb7 into Finschia:main Jul 27, 2022
@tnasu tnasu deleted the main-tmdb branch July 27, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants