Main patch from tm-v0.34.16 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reduce some logs * reduce error logs * remove debug Co-authored-by: Marko <[email protected]>
…7617)
* consensus: calculate prevote message delay metric (#7551)
This pull requests adds two metrics intended for use in calculating an experimental value for `MessageDelay`.
The metrics are as follows:
```
tendermint_consensus_complete_prevote_message_delay{chain_id="test-chain-aZbwF1"} 0.013025505
tendermint_consensus_quorum_prevote_message_delay{chain_id="test-chain-aZbwF1"} 0.013025505
```
For more information on what these metrics are calculating, see #7202. The aim is to merge to backport these metrics to v0.34 and run nodes on a few popular chains with these metrics to determine the experimental values for `MessageDelay` on these popular chains and use these to select our default `SynchronyParams.MessageDelay` value.
Gauges allow us to overwrite the metric on each successive observation. We can then capture these metrics over time to track the highest and lowest observed value.
(cherry picked from commit 0c82ceaa5f7964c13247af9b64d72477af9dc973)
* fix merge conflicts
Co-authored-by: William Banfield <[email protected]>
Co-authored-by: William Banfield <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 65.01% 65.21% +0.20%
==========================================
Files 278 278
Lines 37686 37743 +57
==========================================
+ Hits 24500 24614 +114
+ Misses 11396 11344 -52
+ Partials 1790 1785 -5
|
…age delay metric (backport #7625) (#7631)`
…port #7551) (#7617)`
…ckport #7625) (#7631) * consensus: check proposal non-nil in prevote message delay metric (#7625) (cherry picked from commit b6307c42e095c6f8e9e7c2518fb1004cc8f201a1) * fix merge conflicts Co-authored-by: William Banfield <[email protected]> Co-authored-by: William Banfield <[email protected]>
When testing rollback feature in the Cosmos SDK, we found that the app hash in Tendermint after rollback was the value after the latest block, rather than before it. Co-authored-by: Callum Waters <[email protected]> Co-authored-by: yihuang <[email protected]> (cherry picked from commit 8a238fdcb44461a4e029c8e7a4790c2d470d282b) Inline factory function that does not exist in this branch. Co-authored-by: M. J. Fromberger <[email protected]>
tnasu
force-pushed
the
main-tm-v0.34.16
branch
from
60fd60b to
218e5cd
Compare
The various package locks got out of sync, reunify them. Co-authored-by: M. J. Fromberger <[email protected]>
…ckport #7980) (#7997) * Remove master from versions and copy it from the latest. (#7980) (cherry picked from commit f939f962b19d87e7f23ec912e388ac9165fb1ff4)
Co-authored-by: M. J. Fromberger <[email protected]>
tnasu
force-pushed
the
main-tm-v0.34.16
branch
from
7cc3e38 to
00703b5
Compare
torao
added
the
C: enhancement
torao
added
C: release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.34.16
STATUS: commit hash
Additional work