-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main patch tm v0.34.15 #368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 64.47% 65.13% +0.65%
==========================================
Files 274 278 +4
Lines 30698 37686 +6988
==========================================
+ Hits 19792 24546 +4754
- Misses 9133 11358 +2225
- Partials 1773 1782 +9
|
be175cd
to
70b1415
Compare
667f138
to
1578989
Compare
a161efc
to
1a76752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add to description that you are able to deal with this security problem. https://github.com/line/ostracon/security/dependabot |
Co-authored-by: Sam Kleinman <[email protected]>
Co-authored-by: Tess Rinearson <[email protected]>
Co-authored-by: Tess Rinearson <[email protected]>
Co-authored-by: Tess Rinearson <[email protected]>
Co-authored-by: Tess Rinearson <[email protected]>
Co-authored-by: Sam Kleinman <[email protected]>
Co-authored-by: Sam Kleinman <[email protected]>
…size control (tm v0.34.x) (#7230) A workaround for #6729. Add parameters to control buffer sizes for event subscription RPC clients. On some networks, buffering causes clients to be dropped and/or events to be lost. For additional context, see the discussion on #7188. - Add experimental_subscription_buffer_size config parameter - Add experimental_websocket_write_buffer_size config parameter - Add experimental_close_on_slow_client config parameter Co-authored-by: M. J. Fromberger <[email protected]> Co-authored-by: Thane Thomson <[email protected]>
If a subscriber arrives while the pubsub service is shutting down, the existing code will return a nil subscription without error. With unlucky timing, this may lead to a nil indirection panic in the RPC service. To avoid that problem, make sure that when a subscription fails for this reason, we report a non-nil error so that the client will detect it and give up gracefully. Co-authored-by: M. J. Fromberger <[email protected]>
… (#7368) * cmd: add integration test and fix bug in rollback command (#7315) (cherry picked from commit bca2080c01ca9f877019a5db857907866352182e) Co-authored-by: Callum Waters <[email protected]>
…ackport #7315) #7368`
595aa02
to
35bf185
Compare
I rebased this PR once for the |
Got it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
v0.34.15
STATUS: commit hash
Additional work
Upgrade work (v0.34.15 includes a lot of upgrades lib/plugin, so I responded to it all together instead of skipping the commits)
Upgrade work include fixing potential security vulnerabilities