Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main patch tm v0.34.15 #368

Merged
merged 18 commits into from
Feb 25, 2022
Merged

Main patch tm v0.34.15 #368

merged 18 commits into from
Feb 25, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Feb 1, 2022

Description

v0.34.15

STATUS: commit hash

Additional work

  • Add mockrey command: b5f22de
  • Refactor filenames and improve process on github actions: 76cd8da

Upgrade work (v0.34.15 includes a lot of upgrades lib/plugin, so I responded to it all together instead of skipping the commits)

Upgrade work include fixing potential security vulnerabilities

screenshot 2022-02-25 14 56 50

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #368 (35bf185) into main (7320ceb) will increase coverage by 0.65%.
The diff coverage is 67.41%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   64.47%   65.13%   +0.65%     
==========================================
  Files         274      278       +4     
  Lines       30698    37686    +6988     
==========================================
+ Hits        19792    24546    +4754     
- Misses       9133    11358    +2225     
- Partials     1773     1782       +9     
Impacted Files Coverage Δ
abci/types/result.go 18.75% <ø> (ø)
cmd/ostracon/commands/run_node.go 0.00% <0.00%> (ø)
config/toml.go 73.33% <ø> (+5.33%) ⬆️
crypto/armor/armor.go 47.82% <ø> (-4.56%) ⬇️
crypto/secp256k1/secp256k1.go 66.66% <ø> (+4.76%) ⬆️
crypto/secp256k1/secp256k1_nocgo.go 75.67% <ø> (-2.90%) ⬇️
evidence/pool.go 69.42% <0.00%> (-0.87%) ⬇️
libs/bytes/bytes.go 56.25% <ø> (-3.75%) ⬇️
libs/log/logger.go 0.00% <ø> (ø)
libs/log/oc_json_logger.go 42.85% <ø> (ø)
... and 291 more

@tnasu tnasu force-pushed the main-patch-tm-v0.34.15 branch 3 times, most recently from be175cd to 70b1415 Compare February 1, 2022 09:28
@CLAassistant
Copy link

CLAassistant commented Feb 1, 2022

CLA assistant check
All committers have signed the CLA.

@tnasu tnasu force-pushed the main-patch-tm-v0.34.15 branch 8 times, most recently from 667f138 to 1578989 Compare February 4, 2022 09:37
@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Feb 15, 2022
@tnasu tnasu force-pushed the main-patch-tm-v0.34.15 branch 2 times, most recently from a161efc to 1a76752 Compare February 16, 2022 05:11
@tnasu tnasu marked this pull request as ready for review February 16, 2022 05:46
@tnasu tnasu requested review from Kynea0b and torao as code owners February 16, 2022 05:46
torao
torao previously approved these changes Feb 21, 2022
cmd/ostracon/commands/rollback.go Show resolved Hide resolved
crypto/vrf/vrf_coniks.go Show resolved Hide resolved
Kynea0b
Kynea0b previously approved these changes Feb 21, 2022
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b
Copy link
Contributor

Kynea0b commented Feb 21, 2022

Please add to description that you are able to deal with this security problem. https://github.com/line/ostracon/security/dependabot

tnasu and others added 11 commits February 25, 2022 12:15
…size control (tm v0.34.x) (#7230)

A workaround for #6729. Add parameters to control buffer sizes for
event subscription RPC clients. On some networks, buffering causes
clients to be dropped and/or events to be lost.

For additional context, see the discussion on #7188.

- Add experimental_subscription_buffer_size config parameter
- Add experimental_websocket_write_buffer_size config parameter
- Add experimental_close_on_slow_client config parameter

Co-authored-by: M. J. Fromberger <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
If a subscriber arrives while the pubsub service is shutting down, the existing
code will return a nil subscription without error. With unlucky timing, this
may lead to a nil indirection panic in the RPC service.

To avoid that problem, make sure that when a subscription fails for this
reason, we report a non-nil error so that the client will detect it and give up
gracefully.

Co-authored-by: M. J. Fromberger <[email protected]>
… (#7368)

* cmd: add integration test and fix bug in rollback command (#7315)

(cherry picked from commit bca2080c01ca9f877019a5db857907866352182e)

Co-authored-by: Callum Waters <[email protected]>
@tnasu tnasu dismissed stale reviews from Kynea0b and torao via 35bf185 February 25, 2022 03:17
@tnasu tnasu force-pushed the main-patch-tm-v0.34.15 branch from 595aa02 to 35bf185 Compare February 25, 2022 03:17
@tnasu
Copy link
Member Author

tnasu commented Feb 25, 2022

I rebased this PR once for the v1.0.4 release tag. Please review this again after the green light of checks.

@tnasu
Copy link
Member Author

tnasu commented Feb 25, 2022

Please add to description that you are able to deal with this security problem. ?>https://github.com/line/ostracon/security/dependabot

Got it

Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit f100d3f into Finschia:main Feb 25, 2022
@tnasu tnasu deleted the main-patch-tm-v0.34.15 branch February 28, 2022 03:00
@Kynea0b Kynea0b added the P: emergency Priority: Emergency issue label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code P: emergency Priority: Emergency issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants