Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: wrong binary name #338

Merged
merged 2 commits into from
Oct 18, 2021
Merged

bugfix: wrong binary name #338

merged 2 commits into from
Oct 18, 2021

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Oct 15, 2021

Description

Bugfix: testing binary file name

@tnasu tnasu requested review from Kynea0b and torao October 15, 2021 02:30
@tnasu tnasu self-assigned this Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #338 (758ebd8) into main (624b74c) will increase coverage by 0.08%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   62.88%   62.97%   +0.08%     
==========================================
  Files         272      272              
  Lines       30193    30214      +21     
==========================================
+ Hits        18988    19026      +38     
+ Misses       9477     9465      -12     
+ Partials     1728     1723       -5     
Impacted Files Coverage Δ
crypto/sr25519/privkey.go 49.05% <ø> (ø)
crypto/vrf/vrf_r2ishiguro.go 100.00% <ø> (ø)
libs/log/testing_logger.go 0.00% <ø> (ø)
state/execution.go 68.09% <91.66%> (+1.19%) ⬆️
statesync/chunks.go 88.20% <100.00%> (ø)
p2p/pex/pex_reactor.go 80.10% <0.00%> (-1.58%) ⬇️
blockchain/v0/pool.go 81.64% <0.00%> (-1.27%) ⬇️
mempool/reactor.go 82.63% <0.00%> (-0.94%) ⬇️
p2p/conn/connection.go 79.90% <0.00%> (-0.25%) ⬇️
proxy/multi_app_conn.go 50.58% <0.00%> (ø)
... and 7 more

@Kynea0b Kynea0b added the C: bug Classification: Something isn't working label Oct 15, 2021
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit ff4ad82 into Finschia:main Oct 18, 2021
iproudhon pushed a commit to iproudhon/ostracon that referenced this pull request Nov 3, 2021
* bugfix wrong binary name

* (refactor) rename to `oc`
@tnasu tnasu deleted the main-minnor-fix branch November 11, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants