Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load fbridge & fswap store (backport #365) #367

Merged
merged 1 commit into from
May 10, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 10, 2024

Description

This patch adds setupUpgradeStoreLoaders(), which handles store upgrades.

How has this been tested?

  1. Start v3-Rose chain.
  2. Upgrade the chain to v4-Marigold.
  3. Access the new module's state.
    • e.g. fnsad q fswap swaps
  • Expected results:
    • Without the patch: panics
    • With the patch: returns an empty array of swaps.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

This is an automatic backport of pull request #365 done by [Mergify](https://mergify.com).

* Setup upgrade store loaders

* Update CHANGELOG.md

(cherry picked from commit 70f49fd)
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/v4.0.x@98239cb). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release/v4.0.x     #367   +/-   ##
=================================================
  Coverage                  ?   50.17%           
=================================================
  Files                     ?       10           
  Lines                     ?     1425           
  Branches                  ?        0           
=================================================
  Hits                      ?      715           
  Misses                    ?      663           
  Partials                  ?       47           
Files Coverage Δ
app/app.go 82.38% <33.33%> (ø)

@0Tech 0Tech merged commit 29db806 into release/v4.0.x May 10, 2024
44 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v4.0.x/pr-365 branch May 10, 2024 02:37
@zemyblue zemyblue mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants