Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump up finschia-sdk from v0.48.0 to v0.48.1 #297

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Oct 30, 2023

Description

Motivation and context

Ledger connection fails in MacOS v13.6 or later. So, apply the modified finschia-sdk v0.48.1.

How has this been tested?

  • add keys in ledger
./build/fnsad keys add test --coin-type 118 --ledger
  • sign and broadcast bank send tx via ledger
./build/fnsad tx bank send test link1twsfmuj28ndph54k4nw8crwu8h9c8mh3rtx705 1000cony --gas-prices=0.002cony --ledger --chain-id=simd-testing

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@zemyblue zemyblue self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #297 (6db105b) into main (567e517) will not change coverage.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files           9        9           
  Lines        1375     1375           
=======================================
  Hits          676      676           
  Misses        654      654           
  Partials       45       45           

Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue marked this pull request as ready for review October 30, 2023 01:22
@zemyblue zemyblue merged commit 2070a67 into Finschia:main Oct 30, 2023
37 checks passed
@zemyblue zemyblue deleted the feat/finschia-sdk_v0.48.1 branch October 30, 2023 03:08
mergify bot pushed a commit that referenced this pull request Oct 30, 2023
* build: bump up finschia-sdk from v0.48.0 to v0.48.1

Signed-off-by: zemyblue <[email protected]>

* chore: update changelog

Signed-off-by: zemyblue <[email protected]>

---------

Signed-off-by: zemyblue <[email protected]>
(cherry picked from commit 2070a67)
@zemyblue zemyblue added the bug Something isn't working label Oct 30, 2023
zemyblue added a commit that referenced this pull request Oct 30, 2023
…298)

* build: bump up finschia-sdk from v0.48.0 to v0.48.1 (#297)

* build: bump up finschia-sdk from v0.48.0 to v0.48.1

Signed-off-by: zemyblue <[email protected]>

* chore: update changelog

Signed-off-by: zemyblue <[email protected]>

---------

Signed-off-by: zemyblue <[email protected]>
(cherry picked from commit 2070a67)

* Update CHANGELOG.md

---------

Co-authored-by: zemyblue <[email protected]>
@zemyblue zemyblue mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v2.0.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants