feat!: migrate x/foundation FoundationTax into x/params #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v0.47.x #999 +/- ##
==================================================
Coverage ? 62.00%
==================================================
Files ? 656
Lines ? 78895
Branches ? 0
==================================================
Hits ? 48921
Misses ? 27289
Partials ? 2685 |
0Tech
added
the
A: State Machine Breaking
zemyblue
reviewed
May 15, 2023
Co-authored-by: zemyblue <[email protected]>
zemyblue
approved these changes
May 16, 2023
loin3
approved these changes
May 16, 2023
4 tasks
0Tech
added a commit
to Finschia/finschia
that referenced
this pull request
May 23, 2023
* Bump github.com/Finschia/finschia-sdk from v0.47.0 to v0.47.1-0.20230517010045-e9fe90608161 * Set an upgrade handler for Daisy * Update CHANGELOG.md * Update CHANGELOG.md
zemyblue
pushed a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jul 4, 2023
* Remove relevant messages from proto * Remove relevant logics from x/foundation * Use x/param * Add migration logic * Update docs * Update CHANGELOG.md * Update x/foundation/foundation.go Co-authored-by: zemyblue <[email protected]> * Revert lint on protos --------- Co-authored-by: zemyblue <[email protected]> (cherry picked from commit e9fe906)
5 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would migrate x/foundation
FoundationTaxinto x/params.This task consists of following items:
Also, because it's a breaking change,
Motivation and context
It's a request from the planning team.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml