-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not to throw error when no txs in block #982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loin3
force-pushed
the
fix/getBlockWithTxs
branch
from
April 18, 2023 11:33
f46aa5a
to
3775766
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## rc/v0.47.0-alpha1 #982 +/- ##
=====================================================
- Coverage 62.08% 62.08% -0.01%
=====================================================
Files 655 655
Lines 79041 79041
=====================================================
- Hits 49076 49075 -1
- Misses 27283 27284 +1
Partials 2682 2682
|
zemyblue
approved these changes
Apr 19, 2023
0Tech
approved these changes
Apr 19, 2023
jaeseung-bae
approved these changes
Apr 19, 2023
4 tasks
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Apr 21, 2023
* rc/v0.47.0-alpha1: (34 commits) ci: update docker action (Finschia#983) fix: revert Finschia#952 (Finschia#984) refactor: refactor x/token,collection query errors (Finschia#980) fix: not to throw error when no txs in block (Finschia#982) chore: change import path to `github.com/Finschia/finschia-sdk` (Finschia#970) fix: remove legacy events on x/collection and x/token (Finschia#966) chore: provide specific error messages on x/collection queries (Finschia#965) fix: check event determinism on original modules (Finschia#963) fix: refactor queries of x/collection and x/token (Finschia#957) chore: address generation of the empty coins in x/foundation (Finschia#952) fix: do not loop enum in x/collection (Finschia#961) fix: fix default next class ids of x/collection (Finschia#960) fix: revert Finschia#955 and add Query/HasParent into x/collection (Finschia#959) fix: replace query errors on the original modules into gRPC ones (Finschia#956) fix: return nil where the parent not exists in x/collection Query/Parent (Finschia#955) fix: remove duplicated events in x/collection Msg/Modify (Finschia#954) fix: allow zero amount of coin in x/collection Query/Balance (Finschia#953) fix: unpack proposals in x/foundation import-genesis (Finschia#947) fix: fix broken x/foundation invariant on treasury (Finschia#946) docs: update comments in the x/token,collection events proto (Finschia#944) ...
Merged
5 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I followd this cosmos-sdk/issues/12040 and cosmos-sdk/pull/12108
our version 0.45.x does not have
GetBlockWithTxs
inx/auth/tx/service
, so we createx/auth/tx2
.It's hard to cherr-pick because the directories are different. So I reflected the changes directly into tx2.
Motivation and context
When query through
GetBlockWithTxs
,invalid request
error occurred when no txs are included in block.The correct behavior is to return the block with empty list of txs.
How has this been tested?
tested no error occured and return 0 length of tx list
Screenshots (if appropriate):
before thsi PR, when tx does not exist in block
when tx does not exist in block
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml