Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove bech32-cache-size #665

Merged

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Sep 5, 2022

Description

remove bech32-cache-size from config.toml
closes: #664

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 self-assigned this Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #665 (fbc4faa) into main (86ccc34) will decrease coverage by 0.04%.
The diff coverage is 55.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   60.23%   60.19%   -0.05%     
==========================================
  Files         815      817       +2     
  Lines       94895    95011     +116     
==========================================
+ Hits        57163    57193      +30     
- Misses      34255    34347      +92     
+ Partials     3477     3471       -6     
Impacted Files Coverage Δ
server/config/config.go 44.92% <ø> (ø)
server/config/toml.go 20.00% <ø> (ø)
simapp/test_access.go 0.00% <0.00%> (ø)
x/wasm/keeper/snapshotter.go 65.51% <65.51%> (ø)
simapp/test_helpers.go 8.57% <66.66%> (+1.85%) ⬆️
simapp/app.go 87.00% <77.77%> (-0.53%) ⬇️
x/token/validation.go 69.09% <0.00%> (-18.19%) ⬇️
x/token/msgs.go 26.39% <0.00%> (-10.16%) ⬇️
x/foundation/msgs.go 34.61% <0.00%> (-0.97%) ⬇️
x/foundation/foundation.go 72.92% <0.00%> (-0.37%) ⬇️
... and 2 more

@dudong2 dudong2 requested review from 0Tech, loin3 and zemyblue September 5, 2022 10:51
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix a typo in the title of this PR.

@dudong2 dudong2 changed the title feat: remote bech32-cache-size feat: remove bech32-cache-size Sep 7, 2022
@dudong2 dudong2 merged commit 40de4ce into Finschia:main Sep 7, 2022
@dudong2 dudong2 deleted the dudong2/feat/remove-bech32-cache-size branch September 7, 2022 05:53
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove Bech32CacheSize
3 participants