-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Catch up with address.go in cosmos-sdk v0.45.1 #587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove prefetch functionality and write by multi-threading * apply goimports * fix a few trivial diff
Fix the error test of x/staking
Fix the error test
Fix/issue578 x bank
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 60.60% 60.43% -0.17%
==========================================
Files 814 814
Lines 94798 95261 +463
==========================================
+ Hits 57448 57575 +127
- Misses 34097 34339 +242
- Partials 3253 3347 +94
|
Fix to use sdk.AccAddressFromBech32 from sdk.AccAddress
Fix the error handling when using AccAddressFromBech32
This PR will be handed over to #603. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enable to catch up with address.go in cosmos-sdk v0.45.1.
closes: #578
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml