Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump Go from 1.20 to 1.22 #1410

Merged
merged 8 commits into from
Jun 7, 2024
Merged

chore(deps): Bump Go from 1.20 to 1.22 #1410

merged 8 commits into from
Jun 7, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Jun 7, 2024

Description

closes: #XXXX

Motivation and context

  • Replace Go version of go.mod/Github action/Docker

How has this been tested?

  • Test Environment - Use 4 nodes for testing

    • Node 1, 2 : fnsad built by Go 1.20
    • Node 3, 4 : fnsad built by Go 1.22.4
  • Test Scenario

    1. Set up 4 validators
    2. Connect four nodes each other (4P2)
    3. Send bank tx to Node1, Node3
    4. Verify that transactions are handled correctly and the statuses are queried well in Node2 and Node4
    5. Verify if there is any consensus breaking

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this Jun 7, 2024
@tkxkd0159 tkxkd0159 added dependencies Pull requests that update a dependency file A: build labels Jun 7, 2024
@tkxkd0159 tkxkd0159 requested a review from 170210 June 7, 2024 02:34
@tkxkd0159 tkxkd0159 changed the title Bump Go from 1.20 to 1.22.4 Bump Go from 1.20 to 1.22 Jun 7, 2024
@tkxkd0159 tkxkd0159 changed the title Bump Go from 1.20 to 1.22 chore(deps): Bump Go from 1.20 to 1.22 Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (6c90f1e) to head (d66fbbe).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   70.02%   68.66%   -1.36%     
==========================================
  Files         672      767      +95     
  Lines       56866    63512    +6646     
==========================================
+ Hits        39818    43611    +3793     
- Misses      14775    17234    +2459     
- Partials     2273     2667     +394     
Files Coverage Δ
internal/conv/string.go 100.00% <100.00%> (ø)

... and 96 files with indirect coverage changes

170210
170210 previously approved these changes Jun 7, 2024
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing tools/error_doc's golang version also?

@tkxkd0159 tkxkd0159 requested review from zemyblue and 170210 June 7, 2024 05:37
@tkxkd0159 tkxkd0159 merged commit 7ebd36f into main Jun 7, 2024
38 checks passed
@tkxkd0159 tkxkd0159 deleted the update-go-1.22.4 branch June 7, 2024 07:27
mergify bot pushed a commit that referenced this pull request Jun 7, 2024
* Bump Go from 1.20 to 1.22.4

* follow golangci-lint rule

* Change ghaction go version

* Change the go version of all docker files

* add go version to split-test-files

* Replace slice header because it's deprecated since go 1.21

* Add CHANGELOG

* Update subdirs go version

(cherry picked from commit 7ebd36f)

# Conflicts:
#	.github/workflows/check-generated.yml
#	.github/workflows/lint.yml
#	.github/workflows/release-sims.yml
#	.github/workflows/test.yml
#	CHANGELOG.md
#	go.sum
#	tools/error_doc/go.mod
tkxkd0159 added a commit that referenced this pull request Jun 7, 2024
* Bump Go from 1.20 to 1.22.4

* follow golangci-lint rule

* Change ghaction go version

* Change the go version of all docker files

* add go version to split-test-files

* Replace slice header because it's deprecated since go 1.21

* Add CHANGELOG

* Update subdirs go version
@tkxkd0159 tkxkd0159 added the A: CI label Jun 7, 2024
tkxkd0159 added a commit that referenced this pull request Jun 7, 2024
* chore(deps): Bump Go from 1.20 to 1.22 (#1410)

* Bump Go from 1.20 to 1.22.4

* follow golangci-lint rule

* Change ghaction go version

* Change the go version of all docker files

* add go version to split-test-files

* Replace slice header because it's deprecated since go 1.21

* Add CHANGELOG

* Update subdirs go version

(cherry picked from commit 7ebd36f)

# Conflicts:
#	.github/workflows/check-generated.yml
#	.github/workflows/lint.yml
#	.github/workflows/release-sims.yml
#	.github/workflows/test.yml
#	CHANGELOG.md
#	go.sum
#	tools/error_doc/go.mod

* chore(deps): Bump Go from 1.20 to 1.22 (#1410)

* Bump Go from 1.20 to 1.22.4

* follow golangci-lint rule

* Change ghaction go version

* Change the go version of all docker files

* add go version to split-test-files

* Replace slice header because it's deprecated since go 1.21

* Add CHANGELOG

* Update subdirs go version

* lint

* Update golangci-lint version

* remove inactive linters

* remove generating error docs ci

---------

Co-authored-by: Jaeseung Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: build A: CI backport/v0.49.x dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants