Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add suffix string to docker container (backport #1393) #1403

Merged
merged 1 commit into from
May 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 27, 2024

Description

  • refresh docker container's bound volume which refer to current working directory
  • use current directory as a suffix for docker container to run it per their environment
    • Without refreshing docker container with bound volume location, It doesn't generate proto, swagger depending on the current working directory
    • For example
      • Does work for ~/Finschia/fisnchia-sdk
      • Doesn't work for ~/xxx/finschia-sdk
        • to work this, you should remove docker container first.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1393 done by [Mergify](https://mergify.com).

* build: refresh docker container's bound volume for proto and swagger generation

* Revert "build: refresh docker container's bound volume for proto and swagger generation"

This reverts commit 80d61b1.

* build: add current directory as suffix for docker container

* chore: update changelog

* chore: update pattern

(cherry picked from commit 0b92fe0)
@jaeseung-bae jaeseung-bae self-assigned this May 27, 2024
@jaeseung-bae jaeseung-bae added A: API Breaking Breaking changes that impact APIs and the SDK only (not state machine) A: build and removed A: API Breaking Breaking changes that impact APIs and the SDK only (not state machine) labels May 27, 2024
@jaeseung-bae jaeseung-bae merged commit 464eeed into release/v0.48.x May 27, 2024
42 checks passed
@jaeseung-bae jaeseung-bae deleted the mergify/bp/release/v0.48.x/pr-1393 branch May 27, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants