-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix dummy denom coin data for test in fswap #1392
Conversation
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
+ Coverage 69.57% 69.68% +0.11%
==========================================
Files 668 668
Lines 56231 56242 +11
==========================================
+ Hits 39125 39195 +70
+ Misses 14835 14774 -61
- Partials 2271 2273 +2 |
I think you should change PR title something starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: fix dummy denom coin data for test in fswap Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: fix failed test Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> (cherry picked from commit 6ca08db)
* fix: fix dummy denom coin data for test in fswap Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: fix failed test Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> (cherry picked from commit 6ca08db) Co-authored-by: 170210 <[email protected]>
Description
The
denomMetaData
requires theDisplay
field to appear in DenomUnits. This PR corrects the error dummy coin data in the test data.https://github.com/Finschia/finschia-sdk/blob/main/x/bank/types/metadata.go#L73-L75
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml