Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cli_test for fswap module #1391

Merged
merged 9 commits into from
May 24, 2024
Merged

test: add cli_test for fswap module #1391

merged 9 commits into from
May 24, 2024

Conversation

170210
Copy link
Contributor

@170210 170210 commented May 21, 2024

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@170210 170210 changed the title test: add cli_test for query test: add cli_test for fswap module May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 99.57082% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.05%. Comparing base (e7c6501) to head (4a4938c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   69.57%   70.05%   +0.47%     
==========================================
  Files         668      672       +4     
  Lines       56231    56941     +710     
==========================================
+ Hits        39125    39890     +765     
+ Misses      14835    14776      -59     
- Partials     2271     2275       +4     
Files Coverage Δ
x/fswap/client/testutil/query.go 100.00% <100.00%> (ø)
x/fswap/client/testutil/suite.go 100.00% <100.00%> (ø)
x/fswap/client/testutil/tx.go 100.00% <100.00%> (ø)
x/fswap/client/testutil/grpc.go 98.15% <98.15%> (ø)

... and 4 files with indirect coverage changes

@170210 170210 self-assigned this May 22, 2024
170210 added 2 commits May 22, 2024 13:11
@170210 170210 marked this pull request as ready for review May 22, 2024 04:14
170210 added 2 commits May 22, 2024 13:29
@jaeseung-bae jaeseung-bae added A: improvement Changes in existing functionality backport/v0.49.x labels May 23, 2024
@170210 170210 requested review from jaeseung-bae and 0Tech May 24, 2024 05:06
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 99.51691% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.01%. Comparing base (6ca08db) to head (e4a51f9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   69.68%   70.01%   +0.32%     
==========================================
  Files         668      672       +4     
  Lines       56242    56863     +621     
==========================================
+ Hits        39194    39813     +619     
  Misses      14775    14775              
- Partials     2273     2275       +2     
Files Coverage Δ
x/fswap/client/testutil/query.go 100.00% <100.00%> (ø)
x/fswap/client/testutil/suite.go 100.00% <100.00%> (ø)
x/fswap/client/testutil/tx.go 100.00% <100.00%> (ø)
x/fswap/client/testutil/grpc.go 98.15% <98.15%> (ø)

... and 1 file with indirect coverage changes

@170210 170210 merged commit 621c03f into Finschia:main May 24, 2024
33 checks passed
@170210 170210 deleted the ittests branch May 24, 2024 05:31
mergify bot pushed a commit that referenced this pull request May 24, 2024
* test: add cli_test for query

Signed-off-by: 170210 <[email protected]>

* test: add cli_test for tx

Signed-off-by: 170210 <[email protected]>

* chore: lint fix

Signed-off-by: 170210 <[email protected]>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <[email protected]>

* chore: lint fix

Signed-off-by: 170210 <[email protected]>

* test: add grpc query test

Signed-off-by: 170210 <[email protected]>

* fix: change fromDenom & toDenom

Signed-off-by: 170210 <[email protected]>

* fix: fix for comment

Signed-off-by: 170210 <[email protected]>

---------

Signed-off-by: 170210 <[email protected]>
(cherry picked from commit 621c03f)
170210 added a commit that referenced this pull request May 24, 2024
* test: add cli_test for query

Signed-off-by: 170210 <[email protected]>

* test: add cli_test for tx

Signed-off-by: 170210 <[email protected]>

* chore: lint fix

Signed-off-by: 170210 <[email protected]>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <[email protected]>

* chore: lint fix

Signed-off-by: 170210 <[email protected]>

* test: add grpc query test

Signed-off-by: 170210 <[email protected]>

* fix: change fromDenom & toDenom

Signed-off-by: 170210 <[email protected]>

* fix: fix for comment

Signed-off-by: 170210 <[email protected]>

---------

Signed-off-by: 170210 <[email protected]>
(cherry picked from commit 621c03f)

Co-authored-by: 170210 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants