Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) #1385

Merged
merged 2 commits into from
May 17, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented May 16, 2024

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae added A: bug Something isn't working backport/v0.49.x labels May 16, 2024
@jaeseung-bae jaeseung-bae self-assigned this May 16, 2024
@jaeseung-bae jaeseung-bae force-pushed the fix/missing-event-emission branch from 4e80e5e to 1f29175 Compare May 16, 2024 09:22
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.57%. Comparing base (ed74ee8) to head (232b4ed).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   69.58%   69.57%   -0.01%     
==========================================
  Files         668      668              
  Lines       56208    56213       +5     
==========================================
  Hits        39111    39111              
- Misses      14830    14833       +3     
- Partials     2267     2269       +2     
Files Coverage Δ
x/fswap/keeper/keeper.go 50.86% <20.00%> (-0.68%) ⬇️

... and 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae requested a review from 170210 May 16, 2024 09:31
@jaeseung-bae jaeseung-bae marked this pull request as ready for review May 16, 2024 09:31
@jaeseung-bae jaeseung-bae merged commit baab526 into main May 17, 2024
39 of 40 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/missing-event-emission branch May 17, 2024 00:56
mergify bot pushed a commit that referenced this pull request May 17, 2024
)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata)

* chore: update changelog

(cherry picked from commit baab526)

# Conflicts:
#	CHANGELOG.md
jaeseung-bae added a commit that referenced this pull request May 17, 2024
)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata)

* chore: update changelog
jaeseung-bae added a commit that referenced this pull request May 20, 2024
…ckport #1385) (#1386)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) (#1385)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata)

* chore: update changelog

(cherry picked from commit baab526)

# Conflicts:
#	CHANGELOG.md

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) (#1385)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata)

* chore: update changelog

---------

Co-authored-by: jaeseung-bae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants