-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeseung-bae
force-pushed
the
fix/missing-event-emission
branch
from
May 16, 2024 09:22
4e80e5e
to
1f29175
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 69.58% 69.57% -0.01%
==========================================
Files 668 668
Lines 56208 56213 +5
==========================================
Hits 39111 39111
- Misses 14830 14833 +3
- Partials 2267 2269 +2
|
0Tech
approved these changes
May 16, 2024
zemyblue
approved these changes
May 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2024
) * fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) * chore: update changelog (cherry picked from commit baab526) # Conflicts: # CHANGELOG.md
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
May 20, 2024
…ckport #1385) (#1386) * fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) (#1385) * fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) * chore: update changelog (cherry picked from commit baab526) # Conflicts: # CHANGELOG.md * fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) (#1385) * fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) * chore: update changelog --------- Co-authored-by: jaeseung-bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml