-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support message based proposals (backport #1372) #1373
feat: support message based proposals (backport #1372) #1373
Conversation
* feat: change MakeSwapProposal to foundation proposal * chore: refactor MsgMakeSwapProposal -> MsgSetSwap * chore: clean-up * chore: use original proto stringer interface * chore: remove unused proto annotations * chore: allow gov and foundation as authority address * chore: lint fix * chore: remove redundant part * chore: update changelog (cherry picked from commit 97570b2) # Conflicts: # x/fswap/keeper/proposal.go
Cherry-pick of 97570b2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.49.x #1373 +/- ##
================================================
Coverage 68.86% 68.87%
================================================
Files 675 671 -4
Lines 69204 69197 -7
================================================
- Hits 47660 47657 -3
+ Misses 19264 19260 -4
Partials 2280 2280
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaeseung-bae , please check lint
ci error.
I've checked. This branch use different lint version(v3) to main's one(v6). |
I think this is a problem pr. #1355 :) How about pushing and completing PR whitch matches the lint version first and then solving this? |
Oh. #1374 PR is registered. |
If we want to fix golang-lint error, we need to modify the golangci setting of this file. https://github.com/Finschia/finschia-sdk/blob/release/v0.49.x/.golangci.yml Let's fix it later PR. |
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
This is an automatic backport of pull request #1372 done by [Mergify](https://mergify.com).