Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/fbridge): set target denom as module parameters (backport #1366) #1368

Merged
merged 1 commit into from
May 8, 2024

feat(x/fbridge): set target denom as module parameters (#1366)

c839b92
Select commit
Loading
Failed to load commit list.
Merged

feat(x/fbridge): set target denom as module parameters (backport #1366) #1368

feat(x/fbridge): set target denom as module parameters (#1366)
c839b92
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2024 in 0s

68.87% (target 50.00%)

View this Pull Request on Codecov

68.87% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 28.00000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 68.87%. Comparing base (74e5686) to head (c839b92).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1368      +/-   ##
===================================================
- Coverage            68.90%   68.87%   -0.03%     
===================================================
  Files                  675      675              
  Lines                69167    69199      +32     
===================================================
+ Hits                 47657    47659       +2     
- Misses               19231    19260      +29     
- Partials              2279     2280       +1     
Files Coverage Δ
simapp/app.go 82.28% <100.00%> (ø)
x/fbridge/keeper/keeper.go 72.04% <100.00%> (-0.30%) ⬇️
x/fbridge/keeper/params.go 82.35% <100.00%> (+5.42%) ⬆️
x/fbridge/keeper/transfer.go 71.87% <100.00%> (ø)
x/fbridge/types/codec.go 56.41% <50.00%> (-0.35%) ⬇️
x/fbridge/types/genesis.go 0.00% <0.00%> (ø)
x/fbridge/keeper/genesis.go 8.82% <0.00%> (-1.79%) ⬇️
x/fbridge/types/msgs.go 0.00% <0.00%> (ø)
x/fbridge/types/params.go 35.55% <0.00%> (-3.47%) ⬇️
x/fbridge/keeper/msg_server.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes