Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/fbridge): set target denom as module parameters #1366

Merged
merged 6 commits into from
May 8, 2024

use sdk denom checker

be50a04
Select commit
Loading
Failed to load commit list.
Merged

feat(x/fbridge): set target denom as module parameters #1366

use sdk denom checker
be50a04
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2024 in 0s

69.50% (target 50.00%)

View this Pull Request on Codecov

69.50% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 29.54545% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 69.50%. Comparing base (5e2cd7f) to head (be50a04).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   69.53%   69.50%   -0.04%     
==========================================
  Files         672      672              
  Lines       56111    56154      +43     
==========================================
+ Hits        39019    39029      +10     
- Misses      14827    14858      +31     
- Partials     2265     2267       +2     
Files Coverage Δ
simapp/app.go 80.06% <100.00%> (ø)
x/fbridge/keeper/keeper.go 72.09% <100.00%> (-0.33%) ⬇️
x/fbridge/keeper/params.go 86.66% <100.00%> (+3.33%) ⬆️
x/fbridge/keeper/transfer.go 74.54% <100.00%> (ø)
x/fbridge/types/codec.go 54.28% <50.00%> (-0.26%) ⬇️
x/fbridge/types/genesis.go 0.00% <0.00%> (ø)
x/fbridge/keeper/genesis.go 8.47% <0.00%> (-1.88%) ⬇️
x/fbridge/types/msgs.go 0.00% <0.00%> (ø)
x/fbridge/types/params.go 38.88% <0.00%> (-3.54%) ⬇️
x/fbridge/keeper/msg_server.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes