Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add role-based access control for bridge (backport #1358) #1360

Merged
merged 4 commits into from
May 7, 2024

Conversation

tkxkd0159
Copy link
Member

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 30.61798% with 494 lines in your changes are missing coverage. Please review.

Project coverage is 68.90%. Comparing base (98da17d) to head (a490670).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1360      +/-   ##
===================================================
- Coverage            69.33%   68.90%   -0.43%     
===================================================
  Files                  666      675       +9     
  Lines                68371    69140     +769     
===================================================
+ Hits                 47406    47643     +237     
- Misses               18718    19220     +502     
- Partials              2247     2277      +30     
Files Coverage Δ
simapp/app.go 82.28% <100.00%> (ø)
x/fbridge/types/codec.go 56.75% <50.00%> (ø)
x/fbridge/keeper/params.go 76.92% <76.92%> (ø)
x/fbridge/types/msgs.go 0.00% <0.00%> (ø)
x/fbridge/types/fbridge.go 0.00% <0.00%> (ø)
x/fbridge/keeper/keeper.go 68.13% <69.73%> (+15.19%) ⬆️
x/fbridge/types/keys.go 0.00% <0.00%> (ø)
x/fbridge/types/params.go 39.02% <39.02%> (ø)
x/fbridge/keeper/genesis.go 10.60% <10.00%> (+10.60%) ⬆️
x/fbridge/keeper/abci.go 0.00% <0.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

jaeseung-bae
jaeseung-bae previously approved these changes May 7, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
0Tech
0Tech previously approved these changes May 7, 2024
@tkxkd0159 tkxkd0159 dismissed stale reviews from 0Tech and jaeseung-bae via a490670 May 7, 2024 13:38
@tkxkd0159 tkxkd0159 merged commit 3301445 into release/v0.49.x May 7, 2024
30 of 31 checks passed
@tkxkd0159 tkxkd0159 deleted the bp1358-049 branch May 7, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants