feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) #1345

170210 · 2024-04-26T08:47:19Z

Description

Add fswap module's basic functionality
- Swap, SwapAll, MakeSwapProposal

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: 170210 <[email protected]>

codecov · 2024-04-26T08:53:53Z

Codecov Report

Attention: Patch coverage is 39.53488% with 260 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (pjdp1@8d79d25). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff            @@
##             pjdp1    #1345   +/-   ##
========================================
  Coverage         ?   69.97%           
========================================
  Files            ?      663           
  Lines            ?    55444           
  Branches         ?        0           
========================================
  Hits             ?    38797           
  Misses           ?    14415           
  Partials         ?     2232

Files	Coverage Δ
simapp/app.go	`80.06% <100.00%> (ø)`
x/fswap/keeper/calc.go	`100.00% <100.00%> (ø)`
x/fswap/keeper/keys.go	`100.00% <100.00%> (ø)`
x/fswap/handler.go	`77.77% <77.77%> (ø)`
x/fswap/module_simulation.go	`9.09% <0.00%> (ø)`
x/fswap/types/config.go	`0.00% <0.00%> (ø)`
x/fswap/types/codec.go	`41.17% <43.75%> (ø)`
x/fswap/keeper/msg_server.go	`60.00% <60.00%> (ø)`
x/fswap/types/genesis.go	`36.84% <31.25%> (ø)`
x/fswap/types/proposal.go	`11.76% <11.76%> (ø)`
... and 6 more

x/fswap/client/cli/tx.go

x/fswap/keeper/genesis.go

x/fswap/keeper/keeper.go

x/fswap/types/fswap.go

proto/lbm/fswap/v1/tx.proto

x/fswap/keeper/keeper.go

…rors start with number 2

x/fswap/keeper/expected_keepers.go

x/fswap/keeper/genesis.go

x/fswap/keeper/keeper.go

x/fswap/keeper/proposal.go

x/fswap/types/msgs.go

proto/lbm/fswap/v1/fswap.proto

x/fswap/keeper/proposal.go

…re than limit

x/fswap/types/codec.go

* feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: initialize fswap module (Finschia#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (Finschia#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (Finschia#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (Finschia#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (Finschia#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: introduce new modules(fswap, fbridge) (#1352) * feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]> * chore: lint fix --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

170210 added 6 commits April 26, 2024 17:28

refactor: fswap module's proto

c4ff578

Signed-off-by: 170210 <[email protected]>

refactor: remove config&params and modify genesis

93a97a6

Signed-off-by: 170210 <[email protected]>

refactor: use gov/proposal to change fswapInit

5a8dd65

Signed-off-by: 170210 <[email protected]>

chore: fix simulation

df7355d

Signed-off-by: 170210 <[email protected]>

chore: correct query cli

4c8a928

Signed-off-by: 170210 <[email protected]>

chore: add query for test

015c224

Signed-off-by: 170210 <[email protected]>

jaeseung-bae added 5 commits April 26, 2024 19:16

chore: lint fix

4701f3e

chore: fix for tx cli

a139b67

chore: update proto

60d0112

chore: update genesis logic

f1e6811

chore: add basic tx and queries

427da10

jaeseung-bae mentioned this pull request Apr 30, 2024

feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query) #1341

Closed

5 tasks

jaeseung-bae changed the title ~~refactor: refactor fswap module with gov/proposal~~ feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) Apr 30, 2024

0Tech reviewed Apr 30, 2024

View reviewed changes

jaeseung-bae added 2 commits April 30, 2024 15:11

chore: rename fswap to swap

9b26d2f

chore: change old/new to from/to

6aecac6

jaeseung-bae force-pushed the fswap_refactor branch from 547c5d6 to 6aecac6 Compare April 30, 2024 07:34

chore: clean-up

5195f88

0Tech reviewed Apr 30, 2024

View reviewed changes

proto/lbm/fswap/v1/tx.proto Outdated Show resolved Hide resolved

x/fswap/keeper/keeper.go Outdated Show resolved Hide resolved

jaeseung-bae added 3 commits April 30, 2024 19:38

chore: clean errors and rename

6151a0c

chore: update proto

be5f723

chore: clean unnecessary member variables

e2ac84c

0Tech reviewed Apr 30, 2024

View reviewed changes

x/fswap/keeper/keeper.go Outdated Show resolved Hide resolved

chore: update proto, introduce config, clean code

8b1afaf

jaeseung-bae force-pushed the fswap_refactor branch from 00e23a9 to 8b1afaf Compare May 2, 2024 00:12

jaeseung-bae added 2 commits May 2, 2024 09:19

chore: remove redundant denom validation

edc1df6

chore: remove cache-like operation, rename swap proposal in proto, er…

f59a2c3

…rors start with number 2

0Tech reviewed May 2, 2024

View reviewed changes

chore: apply feedbacks

8e3e634

fix:

4b49115

jaeseung-bae force-pushed the fswap_refactor branch from 45298fd to 4b49115 Compare May 3, 2024 07:55

zemyblue reviewed May 3, 2024

View reviewed changes

proto/lbm/fswap/v1/fswap.proto Show resolved Hide resolved

chore: change error type for temporal test-pass

7ef5b3f

0Tech reviewed May 3, 2024

View reviewed changes

x/fswap/keeper/proposal.go Outdated Show resolved Hide resolved

jaeseung-bae added 2 commits May 3, 2024 18:30

chore: fix for make-swap-proposal update

f3d7632

chore: fix to check swap count after increase in order not to make mo…

9854cf3

…re than limit

0Tech previously approved these changes May 3, 2024

View reviewed changes

jaeseung-bae added 2 commits May 3, 2024 20:28

chore: prevent any proposal with different denom

472d5b4

Merge remote-tracking branch 'origin/pjdp1' into fswap_refactor

3ac87ab

jaeseung-bae dismissed 0Tech’s stale review via 3ac87ab May 3, 2024 11:29

jaeseung-bae requested review from zemyblue and 0Tech May 3, 2024 11:39

0Tech previously approved these changes May 3, 2024

View reviewed changes

chore: change amount cap type

70f9499

jaeseung-bae dismissed 0Tech’s stale review via 70f9499 May 3, 2024 12:00

zemyblue reviewed May 3, 2024

View reviewed changes

x/fswap/types/codec.go Outdated Show resolved Hide resolved

zemyblue reviewed May 3, 2024

View reviewed changes

x/fswap/types/codec.go Outdated Show resolved Hide resolved

jaeseung-bae added 2 commits May 3, 2024 21:38

chore: fix codec-related parts

ebefc77

chore: minor change for convert to-coin-amount-cap

99f9193

jaeseung-bae requested a review from 0Tech May 3, 2024 12:51

zemyblue approved these changes May 3, 2024

View reviewed changes

0Tech approved these changes May 3, 2024

View reviewed changes

jaeseung-bae merged commit 956d7a6 into pjdp1 May 3, 2024
33 checks passed

jaeseung-bae deleted the fswap_refactor branch May 3, 2024 13:15

zemyblue mentioned this pull request May 27, 2024

Release finschia-sdk v0.49.0 #1404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) #1345

feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) #1345

170210 commented Apr 26, 2024 •

edited by jaeseung-bae

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading

feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) #1345

feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) #1345

Conversation

170210 commented Apr 26, 2024 • edited by jaeseung-bae Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented Apr 26, 2024 • edited Loading

Codecov Report

170210 commented Apr 26, 2024 •

edited by jaeseung-bae

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading