feat: initialize fswap module #1336

170210 · 2024-04-11T11:24:41Z

Description

initialize fswap module

make proto file
prepare module template

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: 170210 <[email protected]>

170210 · 2024-04-11T11:25:43Z

Is it necessary to update CHANGLOG.md

jaeseung-bae · 2024-04-11T11:29:02Z

Is it necessary to update CHANGLOG.md

I'm not sure.
I think, It's okay to update changelog once when we launch this module to main branch.

Signed-off-by: 170210 <[email protected]>

codecov · 2024-04-12T04:43:20Z

Codecov Report

Attention: Patch coverage is 14.10256% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 70.30%. Comparing base (55b6566) to head (fea7a93).

Additional details and impacted files

@@            Coverage Diff             @@
##            pjdp1    #1336      +/-   ##
==========================================
- Coverage   70.38%   70.30%   -0.08%     
==========================================
  Files         643      654      +11     
  Lines       54793    54871      +78     
==========================================
+ Hits        38564    38575      +11     
- Misses      14054    14121      +67     
  Partials     2175     2175

Files	Coverage Δ
x/fswap/types/genesis.go	`100.00% <100.00%> (ø)`
x/fswap/types/keys.go	`0.00% <0.00%> (ø)`
x/fswap/keeper/params.go	`0.00% <0.00%> (ø)`
x/fswap/types/codec.go	`0.00% <0.00%> (ø)`
x/fswap/types/params.go	`66.66% <66.66%> (ø)`
x/fswap/handler.go	`0.00% <0.00%> (ø)`
x/fswap/keeper/grpc_query.go	`0.00% <0.00%> (ø)`
x/fswap/genesis.go	`0.00% <0.00%> (ø)`
x/fswap/keeper/msg_server.go	`0.00% <0.00%> (ø)`
x/fswap/keeper/keeper.go	`0.00% <0.00%> (ø)`
... and 1 more

170210 · 2024-04-12T04:45:50Z

Please ignore codecov, this is just a initial template.

Signed-off-by: 170210 <[email protected]>

proto/lbm/fswap/v1/genesis.proto

proto/lbm/fswap/v1/params.proto

proto/lbm/fswap/v1/query.proto

proto/lbm/fswap/v1/tx.proto

proto/lbm/fswap/v1/event.proto

proto/lbm/fswap/v1/params.proto

proto/lbm/fswap/v1/tx.proto

Signed-off-by: 170210 <[email protected]>

170210 · 2024-04-15T07:16:06Z

Should I remove this part. I think it should be init in genesis.go, because this is calculated by the current fnsa amounts.

finschia-sdk/proto/lbm/fswap/v1/params.proto

Lines 13 to 15 in 65b25b8

    
           // upper limit in new coin that this module can swap 
        
           cosmos.base.v1beta1.Coin new_coin_swap_total_limit = 1 
        
               [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/Finschia/finschia-sdk/types.Coin"];

proto/lbm/fswap/v1/genesis.proto

proto/lbm/fswap/v1/params.proto

x/fswap/genesis.go

x/fswap/keeper/keeper.go

x/fswap/module.go

x/fswap/types/msgs.go

Signed-off-by: 170210 <[email protected]>

zemyblue

Can we query the swap rate?

170210 · 2024-04-16T11:16:17Z

I heard that it is a constant value. Should we make a query for it? If it is needed, I think we can add it to the following query.

finschia-sdk/proto/lbm/fswap/v1/query.proto

Lines 25 to 29 in 4e0771a

    
           message QueryTotalSwappableAmountRequest {} 
        
           message QueryTotalSwappableAmountResponse { 
        
             cosmos.base.v1beta1.Coin swappable_new_coin_amount = 1 
        
                 [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/Finschia/finschia-sdk/types.Coin"]; 
        
           }

Signed-off-by: 170210 <[email protected]>

x/fswap/simulation/simap.go

x/fswap/types/params.go

x/fswap/module.go

Signed-off-by: 170210 <[email protected]>

* feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: initialize fswap module (Finschia#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (Finschia#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (Finschia#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (Finschia#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (Finschia#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: introduce new modules(fswap, fbridge) (#1352) * feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]> * chore: lint fix --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

170210 added 7 commits April 9, 2024 19:41

feat: initial fswap module

dc296bc

Signed-off-by: 170210 <[email protected]>

chore: correct dependencies

a1fec2a

Signed-off-by: 170210 <[email protected]>

chore: remove unuse files

fbea8d7

Signed-off-by: 170210 <[email protected]>

feat: add proto files

19ff1d8

Signed-off-by: 170210 <[email protected]>

chore: make proto-gen

8194e85

Signed-off-by: 170210 <[email protected]>

chore: fix compile error

f3ef7ee

Signed-off-by: 170210 <[email protected]>

chore: add new field in params proto

41f6570

Signed-off-by: 170210 <[email protected]>

170210 self-assigned this Apr 11, 2024

170210 marked this pull request as ready for review April 11, 2024 11:26

170210 requested review from tkxkd0159, zemyblue, 0Tech and jaeseung-bae as code owners April 11, 2024 11:26

170210 marked this pull request as draft April 11, 2024 11:35

fix: fix lint

78e1d4f

Signed-off-by: 170210 <[email protected]>

170210 marked this pull request as ready for review April 12, 2024 04:41

feat: add query&tx commands of fswap module

d26da84

Signed-off-by: 170210 <[email protected]>

jaeseung-bae reviewed Apr 15, 2024

View reviewed changes

tkxkd0159 changed the base branch from feat/x-fswap to pjdp1 April 15, 2024 05:37

170210 added 3 commits April 15, 2024 14:44

fix: fix for comment

42f1930

Signed-off-by: 170210 <[email protected]>

docs: update CHANGLOG.md

ee03483

Signed-off-by: 170210 <[email protected]>

docs: fix error docs

65b25b8

Signed-off-by: 170210 <[email protected]>

170210 requested a review from jaeseung-bae April 15, 2024 05:50

tkxkd0159 reviewed Apr 15, 2024

View reviewed changes

fix: fix consensusversion

f43563d

Signed-off-by: 170210 <[email protected]>

170210 added 2 commits April 15, 2024 18:49

fix: remove route,type&getSignBytes in msgs.go

0b2cab7

Signed-off-by: 170210 <[email protected]>

fix: update proto files

4e0771a

Signed-off-by: 170210 <[email protected]>

170210 force-pushed the feat/fswap branch from e44c61a to 4e0771a Compare April 16, 2024 11:05

170210 requested a review from tkxkd0159 April 16, 2024 11:06

zemyblue reviewed Apr 16, 2024

View reviewed changes

fix: fix NewKeeper

4c1b61a

Signed-off-by: 170210 <[email protected]>

170210 requested a review from zemyblue April 17, 2024 09:44

jaeseung-bae reviewed Apr 17, 2024

View reviewed changes

x/fswap/simulation/simap.go Show resolved Hide resolved

jaeseung-bae previously approved these changes Apr 18, 2024

View reviewed changes

tkxkd0159 reviewed Apr 18, 2024

View reviewed changes

x/fswap/types/params.go Outdated Show resolved Hide resolved

x/fswap/types/params.go Outdated Show resolved Hide resolved

x/fswap/module.go Outdated Show resolved Hide resolved

fix: fix for comment

fea7a93

Signed-off-by: 170210 <[email protected]>

170210 dismissed jaeseung-bae’s stale review via fea7a93 April 18, 2024 05:13

170210 requested review from tkxkd0159 and jaeseung-bae April 18, 2024 05:17

jaeseung-bae approved these changes Apr 18, 2024

View reviewed changes

tkxkd0159 approved these changes Apr 18, 2024

View reviewed changes

170210 merged commit 6afe633 into Finschia:pjdp1 Apr 18, 2024
32 of 33 checks passed

da1suk8 mentioned this pull request Apr 25, 2024

feat: prevent fswap and fbridge module in Submessages Finschia/wasmd#123

Closed

5 tasks

zemyblue mentioned this pull request May 27, 2024

Release finschia-sdk v0.49.0 #1404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: initialize fswap module #1336

feat: initialize fswap module #1336

170210 commented Apr 11, 2024 •

edited

Loading

170210 commented Apr 11, 2024

jaeseung-bae commented Apr 11, 2024 •

edited

Loading

codecov bot commented Apr 12, 2024 •

edited

Loading

170210 commented Apr 12, 2024

170210 commented Apr 15, 2024 •

edited

Loading

zemyblue left a comment

170210 commented Apr 16, 2024

feat: initialize fswap module #1336

feat: initialize fswap module #1336

Conversation

170210 commented Apr 11, 2024 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

170210 commented Apr 11, 2024

jaeseung-bae commented Apr 11, 2024 • edited Loading

codecov bot commented Apr 12, 2024 • edited Loading

Codecov Report

170210 commented Apr 12, 2024

170210 commented Apr 15, 2024 • edited Loading

zemyblue left a comment

Choose a reason for hiding this comment

170210 commented Apr 16, 2024

170210 commented Apr 11, 2024 •

edited

Loading

jaeseung-bae commented Apr 11, 2024 •

edited

Loading

codecov bot commented Apr 12, 2024 •

edited

Loading

170210 commented Apr 15, 2024 •

edited

Loading