Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) (backport #1301) #1309

Merged
merged 3 commits into from
Mar 29, 2024

Merge branch 'release/v0.48.x' into mergify/bp/release/v0.48.x/pr-1301

ff40409
Select commit
Loading
Failed to load commit list.
Merged

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) (backport #1301) #1309

Merge branch 'release/v0.48.x' into mergify/bp/release/v0.48.x/pr-1301
ff40409
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 29, 2024 in 0s

69.78% (target 50.00%)

View this Pull Request on Codecov

69.78% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (a496d32) to head (ff40409).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.48.x    #1309      +/-   ##
===================================================
- Coverage            69.78%   69.78%   -0.01%     
===================================================
  Files                  646      646              
  Lines                67532    67541       +9     
===================================================
+ Hits                 47130    47134       +4     
- Misses               18215    18218       +3     
- Partials              2187     2189       +2     
Files Coverage Δ
x/staking/keeper/validator.go 81.09% <54.54%> (-1.17%) ⬇️