Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch a failed proposal tally from proposal.FinalTallyResult in the gprc query #1304

Merged
merged 4 commits into from
Mar 27, 2024

Merge branch 'main' into fix/tally-grpc

39d1651
Select commit
Loading
Failed to load commit list.
Merged

fix: fetch a failed proposal tally from proposal.FinalTallyResult in the gprc query #1304

Merge branch 'main' into fix/tally-grpc
39d1651
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2024 in 1s

70.43% (target 50.00%)

View this Pull Request on Codecov

70.43% (target 50.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.43%. Comparing base (1038a39) to head (39d1651).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   70.42%   70.43%           
=======================================
  Files         643      643           
  Lines       54730    54730           
=======================================
+ Hits        38546    38547    +1     
+ Misses      14011    14010    -1     
  Partials     2173     2173           
Files Coverage Δ
x/gov/keeper/grpc_query.go 76.38% <100.00%> (ø)

... and 1 file with indirect coverage changes