Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) #1301

Merged
merged 5 commits into from
Mar 26, 2024

Update CHANGELOG.md

f67083a
Select commit
Loading
Failed to load commit list.
Merged

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) #1301

Update CHANGELOG.md
f67083a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 26, 2024 in 0s

70.42% (target 50.00%)

View this Pull Request on Codecov

70.42% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.42%. Comparing base (e86b980) to head (f67083a).
Report is 1 commits behind head on main.

❗ Current head f67083a differs from pull request most recent head 1568641. Consider uploading reports for the commit 1568641 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
- Coverage   70.42%   70.42%   -0.01%     
==========================================
  Files         643      643              
  Lines       54702    54708       +6     
==========================================
+ Hits        38526    38528       +2     
- Misses      14006    14008       +2     
- Partials     2170     2172       +2     
Files Coverage Δ
x/staking/keeper/validator.go 80.95% <50.00%> (-1.27%) ⬇️