fix: use accAddress to compare in validatebasic function in collection & token modules #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n & token modules Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 70.41% 70.42% +0.01%
==========================================
Files 643 643
Lines 54693 54701 +8
==========================================
+ Hits 38512 38525 +13
+ Misses 14009 14006 -3
+ Partials 2172 2170 -2
|
170210
force-pushed
the
fix/validatebasic
branch
from
87b110f to
ab960f2
Compare
Signed-off-by: 170210 <[email protected]>
170210
force-pushed
the
fix/validatebasic
branch
from
ab960f2 to
f4ec723
Compare
170210
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
0Tech
reviewed
Mar 19, 2024
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
ulbqb
approved these changes
Mar 19, 2024
0Tech
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses accAddress instead of address to compare in the
validatebasicfunction in the collection & token modules.Before this PR, it used case-sensitive comparison, thus it would occur a bug when
holderandoperatorare the same but in different capitalization.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml