chore: add more unittest for MsgIssue of x/token
#1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.48.0-rcx #1128 +/- ##
==================================================
+ Coverage 69.76% 69.77% +0.01%
==================================================
Files 645 645
Lines 67469 67482 +13
==================================================
+ Hits 47067 47083 +16
+ Misses 18214 18212 -2
+ Partials 2188 2187 -1
|
tkxkd0159
reviewed
Sep 21, 2023
That's great. But don't you think is it too long to understand total codes? |
I think so, it is vertically too long. But the events in the original one are horizontally too long. |
jaeseung-bae
approved these changes
Sep 21, 2023
tkxkd0159
approved these changes
Sep 22, 2023
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Sep 22, 2023
…ssion * rc/v0.48.0-rcx: chore: add more unittest for `MsgIssue` of x/token (Finschia#1128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml