chore: refactor delete logic not to touch iteration-related things wh…

…ile iteration
Finschia · Mar 26, 2024 · e8987d4 · e8987d4
1 parent 4838021
commit e8987d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tests/go.mod b/tests/go.mod
@@ -219,7 +219,6 @@ replace (
 	github.com/Finschia/finschia-sdk/api => ../api
 	// We always want to test against the latest version of the simapp.
 	github.com/Finschia/finschia-sdk/simapp => ../simapp
-
 	// Fix upstream GHSA-h395-qcrw-5vmq and GHSA-3vp4-m3rf-835h vulnerabilities.
 	// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
 	github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.1

diff --git a/x/bankplus/deprecator.go b/x/bankplus/deprecator.go
@@ -51,8 +51,12 @@ func DeprecateBankPlus(ctx context.Context, bankStoreService store.KVStoreServic
 	iter := storetypes.KVStorePrefixIterator(adapter, inactiveAddrsKeyPrefix)
 	defer iter.Close()
 
+	keys := [][]byte{}
 	for ; iter.Valid(); iter.Next() {
-		err := kvStore.Delete(iter.Key())
+		keys = append(keys, iter.Key())
+	}
+	for _, key := range keys {
+		err := kvStore.Delete(key)
 		if err != nil {
 			return err
 		}